Remove PULL UP segment from signal pin check #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not tested yet. I expect to have a chance within the next 24 hours. |
wait more than one PWM pulse just in case signal source is pulled high
correct logic
|
Ok, However, I think a periodic re-check of signal pin when boot loader is inactive should also be investigated. I am also curios why we may want to check if something is pulling signal low while we are pulling signal high. ? |
|
Closing to revise fix per @AlkaMotors suggestions via discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for no instance of low while PULL UP will always be true.
I do not yet know of a reason to check while PULL UP.