Add option for disabling periodic telemetry and bump version #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freasy
reviewed
Jan 23, 2025
| @@ -2,6 +2,6 @@ | |||
| update this file for new releases | |||
| */ | |||
| #define VERSION_MAJOR 2 | |||
| #define VERSION_MINOR 17 | |||
| #define VERSION_MINOR 18 | |||
There was a problem hiding this comment.
version will only be incremented on release
There was a problem hiding this comment.
I would rather the release tag in main is bumped after the release. Then anything built on main you know is newer than the last release.
Right now, you build a binary from main, and it has the same 2.17 release name.
AlexKlimaj
force-pushed
the
pr-no-period-telem
branch
from
9c72db4 to
be20e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 4 in 1 ESCs, enabling periodic telemetry on more than one ESC could damage MCUs. This adds a config option to disable this feature.