CHANGELOG

amaiya · Dec 19, 2024 · 479afbc · 479afbc
1 parent e19ea89
commit 479afbc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@ Most recent releases are shown at the top. Each release shows:
 - N/A
 
 ### fixed:
-- Temporary fix for chat template issue (#113)
+- Fix for HF chat template issue (#113/#114)
 
 
 ## 0.7.0 (2024-12-16)

diff --git a/nbs/00_llm.base.ipynb b/nbs/00_llm.base.ipynb
@@ -575,8 +575,8 @@
     "                    prompt = U.format_string(prompt_template, prompt=prompt)\n",
     "                stop = stop if stop else self.stop\n",
     "                if self.is_hf():\n",
-    "                    # Temporary fix for ISSUE #113\n",
     "                    tokenizer = llm.llm.pipeline.tokenizer\n",
+    "                    # FIX for #113/#114\n",
     "                    prompt = [{'role':'user', 'content':prompt}] if tokenizer.chat_template else prompt\n",
     "                    # Call HF pipeline directly instead of `invoke`\n",
     "                    # since LangChain is not passing along stop_strings\n",

diff --git a/onprem/llm/base.py b/onprem/llm/base.py
@@ -540,8 +540,8 @@ def prompt(self,
                     prompt = U.format_string(prompt_template, prompt=prompt)
                 stop = stop if stop else self.stop
                 if self.is_hf():
-                    # Temporary fix for ISSUE #113
                     tokenizer = llm.llm.pipeline.tokenizer
+                    # FIX for #113/#114
                     prompt = [{'role':'user', 'content':prompt}] if tokenizer.chat_template else prompt
                     # Call HF pipeline directly instead of `invoke`
                     # since LangChain is not passing along stop_strings