-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add full ESM support via an import
export condition
#1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
14 tasks
# Conflicts: # packages/next-intl/package.json # packages/next-intl/rollup.config.mjs # packages/use-intl/package.json # packages/use-intl/rollup.config.mjs # pnpm-lock.yaml # scripts/getBuildConfig.mjs
…ranslations -> getTranslator
# Conflicts: # packages/next-intl/package.json # packages/use-intl/package.json # pnpm-lock.yaml
# Conflicts: # package.json # packages/next-intl/package.json # packages/use-intl/package.json # pnpm-lock.yaml
Open
3 tasks
# Conflicts: # package.json # packages/next-intl/package.json # packages/next-intl/src/navigation/createLocalizedPathnamesNavigation.test.tsx # packages/next-intl/src/navigation/createSharedPathnamesNavigation.test.tsx # packages/next-intl/src/navigation/react-client/ClientLink.test.tsx # packages/next-intl/src/navigation/react-client/useBasePathname.test.tsx # packages/next-intl/src/navigation/shared/redirects.tsx # packages/next-intl/src/navigation/shared/utils.tsx # packages/next-intl/src/react-client/useFormatter.test.tsx # packages/next-intl/src/react-client/useLocale.test.tsx # packages/next-intl/src/react-client/useNow.test.tsx # packages/next-intl/src/react-client/useTimeZone.test.tsx # packages/next-intl/src/react-client/useTranslations.test.tsx # packages/next-intl/src/runtimes/react-server/getTranslations.tsx # packages/next-intl/src/runtimes/react-server/getTranslator.tsx # packages/next-intl/src/server/react-client/index.test.tsx # packages/next-intl/src/shared/NextIntlClientProvider.test.tsx # packages/next-intl/src/shared/utils.test.tsx # packages/next-intl/src/shared/utils.tsx # packages/next-intl/test/navigation/shared/utils.test.tsx # packages/use-intl/package.json # pnpm-lock.yaml
Closed in favor of #1470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support ESM partially. This PR investigates switching to bunchee to enable full ESM while supporting:
'use client'
directives split bundlesdevelopment
/production
build for ESM to avoidprocess.env.NODE_ENV
checksTODO
react-server
conditional export huozhi/bunchee#575Intl
constructors are still shared (and bundle size doesn't go up)use-intl
example to remove vite overrideRelease docs
Fixes #1153