-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improvements for domain-based routing docs and add MDX docs #1176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # pnpm-lock.yaml
I'll merge this for the time being, but would be curious about feedback if you have any Maiane! :) |
Hey, Jan! 😊 My notes about it:
Overall the improved documentation helps a lot, especially because it gives me more tips on where to find other things I need. But, I still miss a clear path for implementing domain-based internationalization, as it seems I am gathering a lot of information from different parts of the docs and for someone who isn't an advanced developer like me, it's hard to make sense on how all those pieces work together. Thank you for all your efforts. Count on me to help improving the docs. Btw, I've updated the read me on my testing repository based on the new input. |
Relevant changes:
DomainsConfig
#1175. Therefore please updatenext-intl
to the latest versionconfig.ts
in routing docs out of tabs, so this is a bit more prominent (proposed docs). Note that I do think that it's currently a bit error-prone to make sure you're passing the relevant config to the middleware as well as the navigation APIs. I plan on improving the API here to have a guarantee for this (☂️ Umbrella: List of potential features / changes for a major version #779). Additionally, I might include setting up the navigation APIs in the getting started with i18n routing docs, as typically every app needs this.x-forwarded-host
out-of-the-box (e.g. Vercel does this)localePrefix: 'never'
docs (proposed docs)