Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Next.js to 14.0.4 in examples #730

Merged
merged 3 commits into from
Dec 19, 2023
Merged

docs: Update Next.js to 14.0.4 in examples #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea1343b
docs: Update Next.js to 14.0.3 in examples
amannn Dec 19, 2023
5af2416
Remove unused directives 🎉
amannn Dec 19, 2023
1743aff
Fix test
amannn Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@vercel/analytics": "1.1.0",
"clsx": "^1.2.1",
"http-status-codes": "^2.2.0",
"next": "^14.0.3",
"next": "^14.0.4",
"nextra": "^2.13.2",
"nextra-theme-docs": "^2.13.2",
"react": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/example-app-router-migration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"start": "next start"
},
"dependencies": {
"next": "^14.0.3",
"next": "^14.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be better for examples?

Suggested change
"next": "^14.0.4",
"next": "latest",

It's used in next.js examples

https://github.com/vercel/next.js/blob/c4adae89b17a6f64cc0abe8e697a88b9e1df1814/examples/api-routes/package.json#L9

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ahmed! I think it's a good idea to pin the major version of Next.js so we can upgrade in a controlled fashion in case breaking changes are introduced.

"next-intl": "latest",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/example-app-router-next-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"start": "next start"
},
"dependencies": {
"next": "^14.0.3",
"next": "^14.0.4",
"next-auth": "^4.24.4",
"next-intl": "latest",
"react": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/example-app-router-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"lodash": "^4.17.21",
"ms": "2.1.3",
"next": "^14.0.3",
"next": "^14.0.4",
"next-intl": "latest",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/example-app-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"dependencies": {
"clsx": "^1.2.1",
"next": "^14.0.3",
"next": "^14.0.4",
"next-intl": "latest",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/example-pages-router-advanced/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"accept-language-parser": "^1.5.0",
"lodash": "^4.17.21",
"next": "^14.0.3",
"next": "^14.0.4",
"next-intl": "latest",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/example-pages-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"date-fns": "^2.16.1",
"next": "^14.0.3",
"next": "^14.0.4",
"next-intl": "latest",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/next-intl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"eslint": "^8.54.0",
"eslint-config-molindo": "^7.0.0",
"eslint-plugin-deprecation": "^1.4.1",
"next": "^14.0.3",
"next": "^14.0.4",
"path-to-regexp": "^6.2.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
1 change: 0 additions & 1 deletion packages/next-intl/test/navigation/react-client/createLocalizedPathnamesNavigation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ describe("localePrefix: 'as-needed'", () => {
it('passes through unknown options to the Next.js router', () => {
function Component() {
const router = useRouter();
// @ts-expect-error -- Wait for https://github.com/vercel/next.js/pull/59001
router.push('/about', {locale: 'de', scroll: false});
return null;
}
Expand Down
1 change: 0 additions & 1 deletion packages/next-intl/test/navigation/react-client/createSharedPathnamesNavigation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ describe("localePrefix: 'as-needed'", () => {
it('passes through unknown options to the Next.js router', () => {
function Component() {
const router = useRouter();
// @ts-expect-error -- Wait for https://github.com/vercel/next.js/pull/59001
router.push('/about', {locale: 'de', scroll: false});
return null;
}
Expand Down
Loading
Loading