Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdl.ast: fix Array not being indexable by ValueCastable #1013

Merged

Conversation

anuejn
Copy link
Contributor

@anuejn anuejn commented Jan 3, 2024

No description provided.

@anuejn anuejn requested a review from whitequark as a code owner January 3, 2024 13:12
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d9ad62) 86.61% compared to head (e5e3835) 86.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   86.61%   86.62%           
=======================================
  Files          41       41           
  Lines        7039     7041    +2     
  Branches     1676     1677    +1     
=======================================
+ Hits         6097     6099    +2     
  Misses        781      781           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a test.

amaranth/hdl/ast.py Show resolved Hide resolved
@anuejn anuejn force-pushed the anuejn/array_value_castable_fix branch from 947e38d to d8a7e15 Compare January 3, 2024 13:40
@anuejn anuejn force-pushed the anuejn/array_value_castable_fix branch from d8a7e15 to e5e3835 Compare January 3, 2024 13:41
@whitequark whitequark enabled auto-merge January 3, 2024 13:41
@whitequark whitequark added this pull request to the merge queue Jan 3, 2024
Merged via the queue into amaranth-lang:main with commit cc9fe89 Jan 3, 2024
14 checks passed
@whitequark whitequark added this to the 0.5 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants