Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 66: Simulation time. #1461

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

zyp
Copy link
Contributor

@zyp zyp commented Jul 23, 2024

No description provided.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks pretty good--can we have tests?

@zyp zyp changed the title [WIP] Implement RFC 66: Simulation time. Implement RFC 66: Simulation time. Sep 17, 2024
@zyp zyp marked this pull request as ready for review September 17, 2024 21:08
@zyp zyp force-pushed the rfc_66 branch 2 times, most recently from e6ae120 to 07485f3 Compare September 17, 2024 21:37
@whitequark
Copy link
Member

You should add a changelog entry.

Looks good to me on the first pass.

@wanda-phi, could you take a look as well?

amaranth/hdl/_time.py Outdated Show resolved Hide resolved
amaranth/hdl/_time.py Outdated Show resolved Hide resolved
amaranth/hdl/_time.py Outdated Show resolved Hide resolved
amaranth/hdl/_time.py Outdated Show resolved Hide resolved
amaranth/hdl/_time.py Outdated Show resolved Hide resolved
amaranth/sim/_async.py Outdated Show resolved Hide resolved
amaranth/sim/_async.py Outdated Show resolved Hide resolved
amaranth/sim/core.py Outdated Show resolved Hide resolved
amaranth/sim/core.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 92.01681% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (74a4096) to head (54ed9d1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
amaranth/build/plat.py 33.33% 6 Missing ⚠️
amaranth/build/dsl.py 77.77% 3 Missing and 1 partial ⚠️
amaranth/sim/core.py 78.57% 2 Missing and 1 partial ⚠️
amaranth/build/res.py 83.33% 1 Missing and 1 partial ⚠️
amaranth/hdl/_time.py 98.83% 0 Missing and 2 partials ⚠️
amaranth/sim/_async.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   91.15%   91.25%   +0.10%     
==========================================
  Files          43       44       +1     
  Lines       11153    11446     +293     
  Branches     2715     2800      +85     
==========================================
+ Hits        10166    10445     +279     
- Misses        818      827       +9     
- Partials      169      174       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Sep 19, 2024
Merged via the queue into amaranth-lang:main with commit c609025 Sep 19, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants