-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC 66: Simulation time. #1461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks pretty good--can we have tests?
e6ae120
to
07485f3
Compare
You should add a changelog entry. Looks good to me on the first pass. @wanda-phi, could you take a look as well? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 91.15% 91.25% +0.10%
==========================================
Files 43 44 +1
Lines 11153 11446 +293
Branches 2715 2800 +85
==========================================
+ Hits 10166 10445 +279
- Misses 818 827 +9
- Partials 169 174 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c609025
No description provided.