Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.res: allow dir="-" when requesting resources with subsignals. #1499

Merged
merged 1 commit into from
Aug 30, 2024
Merged

build.res: allow dir="-" when requesting resources with subsignals. #1499

merged 1 commit into from
Aug 30, 2024

Conversation

wanda-phi
Copy link
Member

@wanda-phi wanda-phi commented Aug 29, 2024 •
edited
Loading

This makes the only non-deprecated way to do I/O not be a pain when subsignals are involved.

(thanks @meithecatte for the report)

@wanda-phi wanda-phi requested a review from whitequark as a code owner August 29, 2024 19:13
whitequark
whitequark reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I propose a 0.5 backport as well as a small note in changelog. Yes, it's a deprecated API and all that, but it's important enough that we should highlight it.

@wanda-phi
build.res: allow dir="-" when requesting resources with subsignals.
73f3e47 
This makes the only non-deprecated way to do I/O not be a pain when
subsignals are involved.
@wanda-phi
Copy link
Member Author

LGTM, but I propose a 0.5 backport as well as a small note in changelog. Yes, it's a deprecated API and all that, but it's important enough that we should highlight it.

added a changelog entry; 0.5 backport already done

I don't think it's a deprecated API though? I mean, unless we want to play google...

@whitequark
Copy link
Member

I don't think it's a deprecated API though? I mean, unless we want to play google...

I mean, basically all of the functionality of platform.request is expressly recommended to be bypassed in the lib.io docs. That would make it deprecated in my view.

whitequark
whitequark approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whitequark whitequark added this pull request to the merge queue Aug 30, 2024
Merged via the queue into amaranth-lang:main with commit 9243901 Aug 30, 2024
20 checks passed
@wanda-phi wanda-phi deleted the io-dir-dash branch August 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanda-phi @whitequark