hdl._nir: AssignmentList: fix comb_edges_to #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only include the condition of a assignment in the comb edges if the assignment assigns to the bit in question.
whitequark
approved these changes
Sep 19, 2024
Merged
via the queue into
amaranth-lang:main
with commit Sep 19, 2024
8c5ed40
18 of 20 checks passed
|
@rroohhh Please also prepare a backport PR to the 0.5 branch, and let me know if I should do a release. |
|
Please find the backport PR at #1515. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only include the condition of a assignment in the comb edges if the assignment assigns to the bit in question.