Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor._gowin: Add 'add_preferences' override #1530

Merged
merged 1 commit into from
Oct 9, 2024
Merged

vendor._gowin: Add 'add_preferences' override #1530

merged 1 commit into from
Oct 9, 2024

Conversation

jeanthom
Copy link
Contributor

@jeanthom jeanthom commented Oct 9, 2024

Implement 'add_preferences' override for CST files, allowing customizing physical placement of primitive.

This implementation follows what was done in vendor._lattice.

@jeanthom
vendor._gowin: Add 'add_preferences' override
d3c56d7 
Implement 'add_preferences' override for CST files, allowing customizing
physical placement of primitive.
@jeanthom jeanthom requested a review from whitequark as a code owner October 9, 2024 08:45
whitequark
whitequark approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Oct 9, 2024
Merged via the queue into amaranth-lang:main with commit 41762f1 Oct 9, 2024
20 checks passed
@jeanthom jeanthom deleted the jeanthom/gowin-vendor-physical branch October 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanthom @whitequark