Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdl._dsl: use Enum for fsm state signal #1536

Merged
merged 1 commit into from
Oct 20, 2024
Merged

hdl._dsl: use Enum for fsm state signal #1536

merged 1 commit into from
Oct 20, 2024

Conversation

rroohhh
Copy link
Contributor

@rroohhh rroohhh commented Oct 17, 2024

This means the enum_{base_type,value_*} attributes will be emitted on rtlil export.

(Also fixes the src_loc_at, which used to point at contextlib)

@rroohhh rroohhh requested a review from whitequark as a code owner October 17, 2024 13:12
whitequark
whitequark approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Oct 20, 2024
Merged via the queue into amaranth-lang:main with commit ef4f68a Oct 20, 2024
18 of 19 checks passed
@rroohhh rroohhh deleted the fsm_state_enum branch October 20, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rroohhh @whitequark