Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC 20: Deprecate non-FWFT FIFOs. #945

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Implement RFC 20: Deprecate non-FWFT FIFOs. #945

merged 3 commits into from
Oct 24, 2023

Conversation

wanda-phi
Copy link
Member

Tracking issue #875.

@wanda-phi wanda-phi requested a review from whitequark as a code owner October 24, 2023 20:39
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #945 (c68bed0) into main (e53d784) will increase coverage by 0.09%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   83.67%   83.76%   +0.09%     
==========================================
  Files          54       54              
  Lines        7686     7736      +50     
  Branches     1868     1886      +18     
==========================================
+ Hits         6431     6480      +49     
  Misses       1052     1052              
- Partials      203      204       +1
Files Coverage Δ
amaranth/lib/fifo.py 94.86% <98.24%> (+0.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

whitequark
whitequark approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This PR completes one of the 0.4 release milestone items, so it's really helpful ^_^

@whitequark whitequark mentioned this pull request Oct 24, 2023
Closed
3 tasks
@whitequark whitequark enabled auto-merge October 24, 2023 20:43
@whitequark whitequark added this pull request to the merge queue Oct 24, 2023
Merged via the queue into amaranth-lang:main with commit 4e4085a Oct 24, 2023
@wanda-phi wanda-phi deleted the deprecate-non-fwft branch October 24, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanda-phi @whitequark