Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 31: Enumeration type safety. #957

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

wanda-phi
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b0b193f) 83.83% compared to head (f49fee2) 84.00%.

Files Patch % Lines
amaranth/lib/enum.py 99.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   83.83%   84.00%   +0.17%     
==========================================
  Files          55       55              
  Lines        7960     8053      +93     
  Branches     1949     1963      +14     
==========================================
+ Hits         6673     6765      +92     
- Misses       1075     1076       +1     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanda-phi wanda-phi force-pushed the enum-type-check branch 4 times, most recently from d846531 to c5e9096 Compare November 25, 2023 12:06
@whitequark whitequark added this to the 0.4 milestone Nov 26, 2023
@wanda-phi wanda-phi force-pushed the enum-type-check branch 2 times, most recently from 229a4a8 to 7707bda Compare November 29, 2023 08:30
@wanda-phi wanda-phi marked this pull request as ready for review November 29, 2023 08:30
docs/stdlib/enum.rst Outdated Show resolved Hide resolved
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work.

@whitequark whitequark enabled auto-merge November 29, 2023 10:50
@whitequark whitequark added this pull request to the merge queue Nov 29, 2023
Merged via the queue into amaranth-lang:main with commit ef5cfa7 Nov 29, 2023
14 checks passed
@wanda-phi wanda-phi deleted the enum-type-check branch November 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants