Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Merge after 0.4 is released) Remove amaranth.lib.scheduler #961

Merged
merged 2 commits into from
Dec 13, 2023
Merged

(Merge after 0.4 is released) Remove amaranth.lib.scheduler #961

merged 2 commits into from
Dec 13, 2023

Conversation

whitequark
Copy link
Member

Closes #874.

@whitequark whitequark added this to the 0.5 milestone Nov 25, 2023
@whitequark whitequark mentioned this pull request Nov 25, 2023
Closed
3 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2f3c54) 83.93% compared to head (e397f7c) 83.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   83.93%   83.93%   -0.01%     
==========================================
  Files          55       54       -1     
  Lines        8057     8024      -33     
  Branches     1966     1954      -12     
==========================================
- Hits         6763     6735      -28     
+ Misses       1082     1076       -6     
- Partials      212      213       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark
Copy link
Member Author

Note: this will need another PR to add a changelog entry after merging.

@whitequark whitequark marked this pull request as ready for review December 13, 2023 09:45
@whitequark whitequark enabled auto-merge December 13, 2023 09:49
@whitequark whitequark added this pull request to the merge queue Dec 13, 2023
Merged via the queue into amaranth-lang:main with commit 475b0f3 Dec 13, 2023
14 checks passed
@whitequark whitequark deleted the remove-scheduler branch December 13, 2023 09:59
@whitequark whitequark mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Implement RFC 19: Remove amaranth.lib.scheduler
1 participant
@whitequark