Move PySim name extraction functionality to Fragment and improve it #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 83.68% 83.67% -0.02%
==========================================
Files 54 54
Lines 7766 7784 +18
Branches 1905 1912 +7
==========================================
+ Hits 6499 6513 +14
- Misses 1058 1062 +4
Partials 209 209 ☔ View full report in Codecov by Sentry. |
At the moment there are two issues with assignment of names in pysim: 1. Names are not deduplicated. It is possible (and frequent) for names to be included twice in VCD output. 2. Names are different compared to what is emitted in RTLIL, Verilog, or CXXRTL output. This commit fixes issue (1), and issue (2) will be fixed by the new IR.
whitequark
force-pushed
the
assign-names
branch
from
4711d54 to
153bc0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there are two issues with assignment of names in pysim:
This PR fixes issue (1), and issue (2) will be fixed by the new IR.