Expand flipped object forwarding in lib.wiring to respect @property and del
#968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 83.68% 83.72% +0.03%
==========================================
Files 54 54
Lines 7766 7809 +43
Branches 1905 1912 +7
==========================================
+ Hits 6499 6538 +39
- Misses 1058 1061 +3
- Partials 209 210 +1 ☔ View full report in Codecov by Sentry. |
whitequark
force-pushed
the
wiring-descriptor-forwarding
branch
from
df480b8 to
48fed8e
Compare
whitequark
force-pushed
the
wiring-descriptor-forwarding
branch
from
48fed8e to
58aeb8e
Compare
wanda-phi
suggested changes
Nov 26, 2023
…nd `del`. Although `@property` is the most common case, any descriptors are now properly supported. The special casing of methods goes away as they work by having functions implement the descriptor protocol. (`__get__` has some special behavior to make this possible.) This is some of the most cursed code I have ever written, yet it is obviously necessary.
whitequark
force-pushed
the
wiring-descriptor-forwarding
branch
from
58aeb8e to
c58eb65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
@propertyis the most common case, any descriptors are now properly supported.The special casing of methods goes away as they work by having functions implement the descriptor protocol. (
__get__has some special behavior to make this possible.)