Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim: disambiguate duplicate names of traced signals #980

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

wanda-phi
Copy link
Member

Fixes #976.

@wanda-phi wanda-phi requested a review from whitequark as a code owner December 3, 2023 00:45
@whitequark whitequark added this to the 0.4 milestone Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ef5cfa7) 84.00% compared to head (f611f0a) 83.95%.
Report is 2 commits behind head on main.

Files Patch % Lines
amaranth/sim/pysim.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   84.00%   83.95%   -0.05%     
==========================================
  Files          55       55              
  Lines        8053     8061       +8     
  Branches     1963     1965       +2     
==========================================
+ Hits         6765     6768       +3     
- Misses       1076     1080       +4     
- Partials      212      213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark enabled auto-merge December 3, 2023 00:50
@whitequark whitequark added this pull request to the merge queue Dec 3, 2023
Merged via the queue into amaranth-lang:main with commit 28139f5 Dec 3, 2023
13 of 14 checks passed
@wanda-phi wanda-phi deleted the vcd-trace-names branch December 3, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

VCD writing with signals having identical names
2 participants