Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC 37: Make Signature immutable. #998

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Implement RFC 37: Make Signature immutable. #998

merged 1 commit into from
Dec 11, 2023

Conversation

wanda-phi
Copy link
Member

Fixes #995.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d0c542) 84.03% compared to head (3f4ab0a) 83.93%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   84.03%   83.93%   -0.10%     
==========================================
  Files          55       55              
  Lines        8098     8057      -41     
  Branches     1976     1964      -12     
==========================================
- Hits         6805     6763      -42     
- Misses       1080     1082       +2     
+ Partials      213      212       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanda-phi wanda-phi force-pushed the signature-immutable branch 2 times, most recently from 8b77492 to 64483c8 Compare December 11, 2023 18:32
whitequark
whitequark reviewed Dec 11, 2023
View reviewed changes
amaranth/lib/wiring.py Outdated Show resolved Hide resolved
whitequark
whitequark approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@whitequark whitequark added this pull request to the merge queue Dec 11, 2023
Merged via the queue into amaranth-lang:main with commit 6ad0d21 Dec 11, 2023
14 checks passed
@wanda-phi wanda-phi deleted the signature-immutable branch December 11, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RFC 37: Signature immutability
2 participants
@wanda-phi @whitequark