Added a language layout switching button #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannes-bichler
force-pushed
the
layout-switch-button
branch
from
52df3c4 to
2d57f93
Compare
AndreaRicchi
force-pushed
the
main
branch
2 times, most recently
from
33a0d09 to
489e5db
Compare
AndreaRicchi
requested changes
Apr 29, 2024
src/qml/CsLayout.qml
Outdated
| @@ -227,7 +227,12 @@ ColumnLayout { | |||
| property real keyWeight: 154 | |||
|
|
|||
| SymbolKey { | |||
| weight: 217 | |||
| weight: availableLanguageLayouts.length === 1? 217 : 108.5 | |||
There was a problem hiding this comment.
This code is not formatted! Also all the other layouts.
There was a problem hiding this comment.
@Johannes-bichler I think this one from
weight: availableLanguageLayouts.length === 1? 217 : 108.5
to
weight: availableLanguageLayouts.length === 1 ? 217 : 108.5
There was a problem hiding this comment.
@panicking I have used the QtCreator included QML Formatter and it worked exactly like you proposed. 😁
src/qml/InputPanel.qml
Outdated
| @@ -135,6 +142,13 @@ Item { | |||
| } | |||
| } | |||
|
|
|||
| Connections{ | |||
| target: InputPanel | |||
| onLanguageLayoutChanged:{ | |||
There was a problem hiding this comment.
@Johannes-bichler from Connections{ to Connections {
src/qml/LanguageKey.qml
Outdated
Johannes-bichler
force-pushed
the
layout-switch-button
branch
from
2d57f93 to
687738a
Compare
Added a button to switch language with an Icon and a property to set a list of available languages as StringList, same Format as languageLayout Reformatted code according to requested changes
Johannes-bichler
force-pushed
the
layout-switch-button
branch
from
687738a to
ec7e7c5
Compare
|
Formatting has been completed and commits were squashed, everything should look fine now. |
AndreaRicchi
approved these changes
Apr 30, 2024
|
@Johannes-bichler you can also use the QML formatter included in the Qt SDK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This keyboard does support multiple layouts, but does not support switching between them at runtime.
For this purpose, I've implemented a button (LanguageKey), that switches between a List of Layouts that can be set via a property (availableLanguageLayouts) in InputPanel.
As this layout switching was added, the Greek Layout was changed to be similar to the others, as the internal layout switcher
(greek-latin) is no longer needed.
If this property is kept empty, it will be automatically set to En, but the property languageLayout overrides this.
If only one language is selected, the layout changer will not be visible.
If an invalid layout is added to the list property, it will fallback to "En".