add pulse metadata flag in PLE user-agent #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
Oct 4, 2023
| @@ -26,6 +26,10 @@ const ( | |||
| // OutputDestination Options | |||
| outputDestinationCloudWatch = "cloudwatch" | |||
| outputDestinationStdout = "stdout" | |||
|
|
|||
| // Pulse EMF config | |||
| pulseMetricNamespace = "AWS/APM" | |||
There was a problem hiding this comment.
Would be good to call all these vars and methods awsApm instead of pulse. Rest LGTM!
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh interesting.. yeah that would need a bunch of changes on the agent side if thats the case. Please let us know once you hear back Min.
sky333999
approved these changes
Oct 5, 2023
lisguo
approved these changes
Oct 10, 2023
|
|
||
| switch { | ||
| case userAgentFlag.isEnhancedContainerInsights && enhancedContainerInsightsEKSPattern.MatchString(logGroupName): | ||
| extraStr = "EnhancedEKSContainerInsights" |
There was a problem hiding this comment.
nit: these flag strings could be consts
lisguo
merged commit fe0f140
into
amazon-contributing:aws-cwa-dev
86 of 87 checks passed
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jun 26, 2024
… exporter (#32998) **Description:** Cherry-picking from downstream: amazon-contributing#105 This PR adds AppSignals metadata flag in user-agent in EMF exporter, so CWLogs backend can indicate EMF logs request type for the corresponding actions --------- Co-authored-by: Min Xia <[email protected]> Co-authored-by: Jeffrey Chien <[email protected]> Co-authored-by: Vastin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add pulse metadata flag in PLE user-agent in EMF exporter, so CWLogs backend can indicate EMF logs request type for the corresponding actions.
Testing:
UnitTest