[extension/awsmiddleware] Set request ID and operation name in context. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhihonl
previously approved these changes
Oct 23, 2023
zhihonl
reviewed
Oct 23, 2023
jefchien
force-pushed
the
set-context-metadata
branch
from
b4e63a9 to
9c61419
Compare
The govulnchecks are known to be broken. So long as it isn't breaking due to changes in this PR, I'm fine with it. |
zhihonl
approved these changes
Oct 23, 2023
bryce-carey
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Moves the request ID into the context and adds the operation name. Placing the metadata into the context makes it more flexible and leaves it open to more metadata in the future. This is similar to how the AWS SDKv2 sets the metadata.
Link to tracking Issue: N/A
Testing: Added unit tests.
Documentation: Updated README.