forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Neuron Scraper for scraping neuron monitor metrics #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dcgm relabeling rules
update dcgm relabeling rules
use constant variables use the same scrape configs in dcgm scraper test remove unnecessary attribute decoration for GPU metrics add dcgm as source for dim
sam6134
requested review from
movence and
straussb
and removed request for
mxiamxia
March 7, 2024 18:17
sam6134
commented
Mar 8, 2024
sam6134
changed the title
Ci neuron
Add Neuron Scraper for scraping neuron monitor metrics
Mar 12, 2024
straussb
previously approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For any future readers, note that this PR was continued from aditya-purang#1
receiver/awscontainerinsightreceiver/internal/neuron/neuron_monitor_scraper_config.go
Show resolved
Hide resolved
movence
reviewed
Mar 19, 2024
receiver/awscontainerinsightreceiver/internal/neuron/neuron_monitor_scraper_config.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/neuron/neuron_monitor_scraper_config.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/gpu/metric_map.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/neuron/pod_attribute_decorator.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/neuron/pod_attribute_decorator.go
Outdated
Show resolved
Hide resolved
straussb
approved these changes
Mar 20, 2024
movence
approved these changes
Mar 20, 2024
sam6134
merged commit Mar 21, 2024
7441665
into
amazon-contributing:aws-cwa-dev
42 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding Neuron Scraper Configs an decorator
CR for initial Reviews on the NeuronScraper
Testing: Deployed on test cluster consumed logs and printed final -