Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remoteXrayExporterDotConverter featuregate.StageBeta To Enable B… #207

Closed
wants to merge 1 commit into from

Conversation

sethAmazon
Copy link

…y Default

Description:
In our fork we allowed . but int he upstream it is feature flagged
I turned the feature flag on by default

Link to tracking Issue:
N/A

Testing:
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8851759610/job/24309612164

Documentation:
N/A

@sethAmazon sethAmazon requested a review from wangzlei as a code owner April 26, 2024 19:44
Copy link

@jefchien jefchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to enable the feature flag without changing the stage status?

@sethAmazon
Copy link
Author

sethAmazon commented Apr 29, 2024

I tried adding to the start collector command in cwa --feature-gates=+exporter.xray.allowDot but it did not work

@sethAmazon sethAmazon closed this Apr 29, 2024
@sethAmazon sethAmazon deleted the add-config-for-xray-allow-dot branch April 29, 2024 14:38
@sethAmazon sethAmazon restored the add-config-for-xray-allow-dot branch April 29, 2024 14:54
@sethAmazon sethAmazon reopened this Apr 29, 2024
@sethAmazon sethAmazon closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants