Add private IPv4 describe instances filter fallback. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitali-salvi
approved these changes
Apr 30, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Same change as aws/amazon-cloudwatch-agent#1149
If the EC2 instance doesn't follow the hostname fixed-format, then the agent needs another way to filter for the instance. The private IPv4 address can also be used as a filter (private-ip-address). There isn't a way to get the region in this case, so the call to EC2 Describe Instances relies on other methods (e.g. the AWS_REGION environment variable) to determine the region to use with the call.
Based on SSM Agent IP retrieval implementation. Uses AZ to determine region if not determined using hostname.
Link to tracking Issue: aws/amazon-cloudwatch-agent#1101
Testing: Added unit tests.
Documentation: N/A