use localNode decorator for DCGM and Neuron metrics for host metadata #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For some edge cases, DCGM or Neuron metrics for ContainerInsights are missing host metadata labels including
InstanceId
and/orInstanceType
. This PR is to use localNode decorator insteadk8sDecorator
to inject those host metadata while processing metrics.Testing:
Tested on a test cluster to verify those metadata are still coming as part of DCGM/Neuron EMF logs (some sections have been redacted)
Documentation: