Target allocator Support for the Agent #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split target allocator into an internal package (open-telemetry#33223) Fixes open-telemetry#33146 * basic working copy * Added k8 test back --------- Co-authored-by: David Ashpole <[email protected]>
sky333999
previously approved these changes
Oct 30, 2024
jefchien
reviewed
Oct 30, 2024
Comment on lines
+32
to
+34
| func getPodName() string { | ||
| return os.Getenv("POD_NAME") | ||
| } |
There was a problem hiding this comment.
nit: Seems like an unnecessary function. It's only ever called in one place and doesn't make things clearer.
jefchien
approved these changes
Oct 30, 2024
sky333999
approved these changes
Oct 30, 2024
movence
reviewed
Oct 30, 2024
| if len(cfgMap) == 0 { | ||
| return nil | ||
| } | ||
| cfgMap["url"] = "http://placeholder" // we have to set it as else marshaling will fail |
There was a problem hiding this comment.
should this be reset after unmarshalling?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Merge Collector Improvements and Bug Fixes
Description:
This pull request merges several improvements and bug fixes related to the CloudWatch Agent Collector and Target Allocator components. The changes include:
Testing:
Related PRs: