Implement new receiver to add prometheus scraper for Kueue metrics #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change: only look in ``kueue-system`` namespace
test: remove unused metrics from test coverage
doc: reword a comment for clarity
change: remove constants for uncaptured metrics change: add new Kueue metric type
rvasahu-amazon
changed the base branch from
aws-cwa-dev
to
kueue-observability
chadpatel
approved these changes
Nov 12, 2024
rvasahu-amazon
merged commit bc82785
into
amazon-contributing:kueue-observability
123 of 135 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is intended to add a new receiver based on the existing AWS Container Insights Receiver for Kueue metrics. This new receiver, much like the control plane metrics scraping capability of the ACIR, essentially creates a scrape config and passes it to a lower-level Prometheus receiver.
Link to tracking Issue: None.
Testing:
Integration tests are being implemented to
amazon-cloudwatch-agent-testin parallel.Documentation: Pending.