Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve PR Workflow issues for OCB Specific Components #254

Conversation

jj22ee
Copy link

@jj22ee jj22ee commented Nov 14, 2024

Description:

Changes:

  • Reduced some of the changes of awscloudwatchlogsexporter between upstream and the fork to ensure unit tests build and pass
    • awscloudwatchlogsexporter is NOT an OCB component
  • In PR workflow, disable crosslink (expects that "replace" is present for all modules) as some of the "replace" statements are removed to reduce conflicts as OCB components may depend on different OTel dependency versions
  • In otelcontribcol test (builds Collector with all components), remove OCB components as they depend on different OTel dependency versions and can cause conflicts
  • Remove "replace" statements for OCB components due to version conflicts

OCB component testing are expected to be tested via a different e2e testing mechanism. The PR workflows are still expected to verify linting and unit tests for OCB components, while they are not used to test building the collector alongside all other components.

Link to tracking Issue:

Testing:

Documentation:

@mxiamxia mxiamxia merged commit 219c634 into amazon-contributing:aws-ocb-dev Nov 15, 2024
140 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants