Fixed the initial nodes expander #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maintain the provided hostname, for TLS hostname verifications.
nihohit
approved these changes
Aug 30, 2023
| } => { | ||
| if let Some(socket_addr) = socket_addr { |
There was a problem hiding this comment.
minor:
let socket_addrs = if let Some(socket_addr) = socket_addr {
socket_addr
} else {
get_socket_addrs(host, port).await?
};
select_ok(
socket_addrs.map(|socket_addr| <T>::connect_tcp_tls(host, socket_addr, insecure)),
)
.await?
.0There was a problem hiding this comment.
get_socket_addrs return an iterator
| @@ -64,6 +64,10 @@ pub enum ConnectionAddr { | |||
| host: String, | |||
There was a problem hiding this comment.
add to doc "This name should remain the DNS name, for the purpose of TLS hostname verification. IP addresses can be saved in socket_addr."
|
Chose option 2: #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the initial nodes expander to return the socketAddr object and maintain the provided hostname, for TLS hostname verifications.
The Subject Alternative Name (SAN) is an extension to the X.509 specification that allows users to specify additional host names for a single SSL certificate. In ElastiCache cluster TLS certificate there is a subject name containing the suffix of the cluster name, e.g.:
*.barshaul-babushka-standalone-test-tls.ez432c.use1.cache.amazonaws.com. When we expand the DNS endpoint to multiple node addresses, we shall save the provided hostname in order to be able to verify the node with the TLS cert.