-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI driver tests #20
Closed
Closed
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b001c76
Add Dockerfile and Docker usage instructions
camerondurham 37bbc9b
Remove unnecessary gcc, g++ deps in builder img
camerondurham 3d384f2
Add build workflow, cleanup README
camerondurham 5126b11
Test: intentionally break build
camerondurham 16cf2b2
Fix build: re-add clang dep
camerondurham 2dae6ea
Add note about Debian dependencies to README
camerondurham 0d16ec9
Merge branch 'amzn:master' into master
camerondurham 7cae483
Add basic, runnable tests
camerondurham 6c5218a
Update ion-rs version, ion-c submodule and Dockerfile
camerondurham 256630c
Merge pull request #2 from camerondurham/upgrade-deps
camerondurham ae9b22b
Merge branch 'amzn:master' into master
camerondurham 0e54cce
Merge branch 'amzn:master' into master
camerondurham 39f03c1
Add basic, runnable tests
camerondurham 0e36543
Add basic workflows for coverage and build
camerondurham 290c4f9
rebase branch and add new Cargo.lock, ion-c changes
camerondurham 784c43e
pin to specific cargo release
camerondurham 1a53227
Make bin match cargo name
camerondurham 5dfab4d
Update Cargo.toml
camerondurham 3f48b37
Add Dockerfile and Docker usage instructions
camerondurham 6e2a445
Remove unnecessary gcc, g++ deps in builder img
camerondurham d853d6e
Add build workflow, cleanup README
camerondurham 20fc2e5
Test: intentionally break build
camerondurham 51ec039
Fix build: re-add clang dep
camerondurham d4b7fa9
Add basic, runnable tests
camerondurham 37ef014
Update ion-rs version, ion-c submodule and Dockerfile
camerondurham 1583eb9
Add basic, runnable tests
camerondurham b7b4fdb
Add basic workflows for coverage and build
camerondurham 33faba8
rebase branch and add new Cargo.lock, ion-c changes
camerondurham 0cd765d
pin to specific cargo release
camerondurham 12a3aa5
Make bin match cargo name
camerondurham 1f20d49
Update Cargo.toml
camerondurham 153b07b
Merge branch 'amzn-master' into cli-tests
camerondurham 7980666
* use 2022 pinned version and fix edition 2021 errors
camerondurham 0534da9
Add test comment, revert ion-c commits, remove failing coverage test …
camerondurham 4b38b93
try updating ion-c submodule to resolve windows build error
camerondurham 20204c9
revert ion-c commits to match main branch
camerondurham a40992d
Remove Windows build due to CMake build failure
camerondurham d3f7faa
try with windows latest
camerondurham 6992c98
remove windows build for now
camerondurham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: CI Build | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
name: Build and Test | ||
runs-on: ${{ matrix.os }} | ||
# We want to run on external PRs, but not on internal ones as push automatically builds | ||
# H/T: https://github.com/Dart-Code/Dart-Code/commit/612732d5879730608baa9622bf7f5e5b7b51ae65 | ||
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != 'amzn/ion-cli' | ||
strategy: | ||
matrix: | ||
# TODO: add windows after fixing cmake version error issues | ||
# see for example Windows build workflow: https://github.com/amzn/ion-rust/blob/a4b154cc0a5b5b661a45ac14d3719a501573d8f2/.github/workflows/rust.yml#L13-L28 | ||
os: [ubuntu-latest, macos-latest] | ||
|
||
steps: | ||
- name: Git Checkout | ||
uses: actions/checkout@v2 | ||
with: | ||
submodules: recursive | ||
- name: Rust Toolchain | ||
uses: actions-rs/toolchain@v1 | ||
with: | ||
profile: minimal | ||
toolchain: stable | ||
override: true | ||
- name: Cargo Build | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: build | ||
args: --verbose --workspace | ||
- name: Cargo Test | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: test | ||
args: --verbose --workspace -- --test-threads=1 | ||
- name: Rustfmt Check | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: fmt | ||
args: --verbose -- --check |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed you fixed this already in #21. Apologies for including too many things in this CR, I'll avoid this in the future. Would it be better if I send a new CR rebased on the main branch with only the commits to add the driver test and workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be really helpful if you don't mind!