Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial ion-1-1 mdbook #333

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Adds initial ion-1-1 mdbook #333

merged 4 commits into from
Aug 19, 2024

Conversation

zslayton
Copy link
Contributor

@zslayton zslayton commented Aug 14, 2024

This PR adds an mdbook port of our existing Asciidocs in a new folder called books. If we like the mdbook publishing experience we can eventually add others--cookbooks, a separate home for Macros by example, etc.

Note that this targets gh-pages rather than the ion-11-specification; this is in the hopes that we can incorporate it into our typical CI/CD build logic and have it auto-publish.

To view the rendered content locally, clone this branch and run:

cargo install mdbook
cargo install mdbook-alerts
mdbook serve

When you run mdbook serve it will run a local http server on port 3000 for you to explore the pages.

You can also view the rich diff for each page in GitHub using the button in the upper right of each file:
image


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton marked this pull request as ready for review August 14, 2024 19:42
@nirosys
Copy link
Contributor

nirosys commented Aug 14, 2024

To view locally, I had to provide the book path: mdbook serve books/ion-1-1

Copy link
Contributor

@nirosys nirosys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. There's a plugin, mdbook-pandoc, if there's a need for auto-building pdfs or other formats too.

@popematt
Copy link
Contributor

We can use this to build both the mdbook and the jekyll site and then publish them together.

books/ion-1-1/src/binary/opcodes.md Outdated Show resolved Hide resolved
books/ion-1-1/src/binary/values/timestamp.md Outdated Show resolved Hide resolved
books/ion-1-1/src/binary_encoding.md Outdated Show resolved Hide resolved
books/ion-1-1/src/macros_by_example.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I attempt to read this file, can you tell me—is this modified from the original in any way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked, and BSD-3-Clause license does allow redistribution with modifications, so there's no problems there. It would be nice if we could somehow put the Ion-specific changes in a separate file so that we can easily locate and identify what is ours and what is from the original.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discussion: this copy of highlight.js includes a language entry for ion, allowing us to customize the syntax highlighting for macros. The current entry is pretty basic, but we can build on it.

I double checked, and BSD-3-Clause license does allow redistribution with modifications, so there's no problems there.

Thanks for confirming this. Copy/paste/edit to override is the customization approach prescribed by mdbook, but it's always good to double check.

It would be nice if we could somehow put the Ion-specific changes in a separate file so that we can easily locate and identify what is ours and what is from the original.

Agreed. Open to ideas here.

books/ion-1-1/src/binary/e_expressions.md Outdated Show resolved Hide resolved
@popematt
Copy link
Contributor

popematt commented Aug 15, 2024

FYI—I don't think that any of my comments are necessarily blocking comments.

@zslayton zslayton merged commit 8b2c565 into gh-pages Aug 19, 2024
1 check passed
@zslayton zslayton deleted the ion-1-1-mdbook branch August 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants