-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds initial ion-1-1
mdbook
#333
Conversation
To view locally, I had to provide the book path: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. There's a plugin, mdbook-pandoc, if there's a need for auto-building pdfs or other formats too.
We can use this to build both the mdbook and the jekyll site and then publish them together. |
books/ion-1-1/theme/highlight.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I attempt to read this file, can you tell me—is this modified from the original in any way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked, and BSD-3-Clause license does allow redistribution with modifications, so there's no problems there. It would be nice if we could somehow put the Ion-specific changes in a separate file so that we can easily locate and identify what is ours and what is from the original.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per offline discussion: this copy of highlight.js
includes a language
entry for ion
, allowing us to customize the syntax highlighting for macros. The current entry is pretty basic, but we can build on it.
I double checked, and BSD-3-Clause license does allow redistribution with modifications, so there's no problems there.
Thanks for confirming this. Copy/paste/edit to override is the customization approach prescribed by mdbook
, but it's always good to double check.
It would be nice if we could somehow put the Ion-specific changes in a separate file so that we can easily locate and identify what is ours and what is from the original.
Agreed. Open to ideas here.
FYI—I don't think that any of my comments are necessarily blocking comments. |
This PR adds an
mdbook
port of our existing Asciidocs in a new folder calledbooks
. If we like themdbook
publishing experience we can eventually add others--cookbooks, a separate home for Macros by example, etc.Note that this targets
gh-pages
rather than theion-11-specification
; this is in the hopes that we can incorporate it into our typical CI/CD build logic and have it auto-publish.To view the rendered content locally, clone this branch and run:
When you run
mdbook serve
it will run a local http server on port3000
for you to explore the pages.You can also view the rich diff for each page in GitHub using the button in the upper right of each file:
![image](https://private-user-images.githubusercontent.com/611616/357981420-843d023d-5223-4b2b-a005-a82ca7fe771d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjUwMDAsIm5iZiI6MTczOTU2NDcwMCwicGF0aCI6Ii82MTE2MTYvMzU3OTgxNDIwLTg0M2QwMjNkLTUyMjMtNGIyYi1hMDA1LWE4MmNhN2ZlNzcxZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMDI1MDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00ZjBkMDJkNDBiZGQxMGYzMTgwYjA2ZDBmYTA5ZTA0ZmIxMzgwMDkyNGIwM2IyY2E4NTAzZjExNDJlZWYwYmM1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.qPY-osvs2ftbvHHG68AtuUB0fn74Wo0ibMEW6ToN0OM)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.