Adds glossary and consolidates grammar #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
reviewed
Oct 18, 2024
_books/ion-1-1/src/glossary.md
Outdated
|
|
||
| **segment**<br/> | ||
| A contiguous partition of a _document_ that uses the same _active encoding module_. Segment boundaries | ||
| are caused by directives: an IVM starts a new segment, while `$ion_symbol_table` and `$ion_encoding` |
There was a problem hiding this comment.
An IVM ends the previous segment (if any) and starts a new one, correct?
zslayton
approved these changes
Oct 31, 2024
Comment on lines
+3
to
+5
| **active encoding module**<br/> | ||
| The _encoding module_ whose symbol table and macro table are available in the current _segment_ of an Ion _document_. | ||
| The active encoding module is set by a _directive_. |
There was a problem hiding this comment.
Thinking out loud, it would be really nice to incorporate something like this pre-processor to make phrases in the spec show their definition on hover.
Having a glossary is great, but not having to leave the page to define a term would be even better.
EDIT: I just saw that preprocessor's first and only issue. 😆
Co-authored-by: Zack Slayton <[email protected]>
Co-authored-by: Zack Slayton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
defining_macros.mdand adds a missing linktrue,false,null,nan) are not identifier symbols.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.