Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto eval workflow #224

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix auto eval workflow #224

merged 3 commits into from
Dec 2, 2024

Conversation

abdulfatir
Copy link
Contributor

@abdulfatir abdulfatir commented Dec 2, 2024

Issue #, if available:

Description of changes: This PR fixes the auto evaluation workflow. The second workflow step did not work because it did not know the right PR number to post the comment on. The fix is to include the PR number in the CSV file name and read it in the second workflow.

PS: This is a really poor user experience because there's no way to test that this works right without merging!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abdulfatir abdulfatir marked this pull request as draft December 2, 2024 09:41
@abdulfatir abdulfatir added the run-eval Run evaluation CI workflow label Dec 2, 2024
@abdulfatir abdulfatir marked this pull request as ready for review December 2, 2024 10:02
@abdulfatir abdulfatir requested a review from lostella December 2, 2024 10:02
@abdulfatir abdulfatir merged commit 86f755c into main Dec 2, 2024
6 checks passed
@abdulfatir abdulfatir deleted the fix-auto-eval-ci branch December 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-eval Run evaluation CI workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants