htmltools rendered #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now it supports href! woohoo. library(ambiorix)
library(plotly)
library(calcite)
library(echarts4r)
library(htmltools)
library(highcharter)
data(penguins, package = "palmerpenguins")
page <- function(...) {
tags$html(
tags$head(
tags$title("The page title!"),
),
tags$body(...)
)
}
# core app
app <- Ambiorix$new()
app$get("/", \(req, res){
shell <- calcite_shell(
calcite_navigation(
slot = "header",
calcite_navigation_logo(
slot = "logo",
heading = "Snow Plow Map",
description = "City of AcmeCo"
),
calcite_menu(
slot = "content-end",
calcite_menu_item(text = "Drivers", `icon-start` = "license", `text-enabled` = TRUE),
calcite_menu_item(text = "Routes", `icon-start` = "road-sign", `text-enabled` = TRUE),
calcite_menu_item(text = "Forecast", `icon-start` = "snow", `text-enabled` = TRUE)
),
calcite_navigation(
slot = "navigation-secondary",
calcite_menu(
slot = "content-start",
calcite_menu_item(breadcrumb = TRUE, text = "All Routes", `icon-start` = "book", `text-enabled` = TRUE),
calcite_menu_item(breadcrumb = TRUE, text = "South Hills", `icon-start` = "apps", `text-enabled` = TRUE, active = TRUE)
)
),
calcite_navigation_user(slot = "user", `full-name` = "Wendell Berry", username = "w_berry")
)
)
ec <- cars |>
echarts4r::e_charts(speed) |>
echarts4r::e_scatter(dist)
pl <- plot_ly(midwest, x = ~percollege, color = ~state, type = "box")
hc <- hchart(
penguins,
"scatter",
hcaes(x = flipper_length_mm, y = bill_length_mm, group = species)
)
p <- page(
h1("Dashboard"),
shell,
div(
class = "grid",
tags$article(pl),
tags$article(ec),
tags$article(hc)
)
)
res$send(p)
})
app$start() |
|
this is great!! i'm on chrome, everything is displayed well. but when i inspect the page, i get this on the R console, can't tell why:
|
JohnCoene
commented
Jan 20, 2025
| # htmltools::renderDependencies(..., srcType = "href") | ||
| # does not work | ||
| rendered_deps <- htmltools::renderDependencies(deps) | ||
| href_deps <- grep("http", strsplit(rendered_deps, "\n")[[1]], value = TRUE) |
There was a problem hiding this comment.
We only take href here so you should not see this in your console, can you make sure you're on the latest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft at fully rendering htmltools.
The core of it sits here:
ambiorix/R/response.R
Line 89 in 981339f
The idea is to check whether the tags contain an
<html>tag, if found it treats it like a "page" and attempts to render a full HTML document.Otherwise, it works as it currently does.
Then it becomes real easy to create something that resembles a more "traditional" shiny app.
What do you think? @kennedymwavu