Refix F-2024-1928 | Use Of Transfer() Instead Of Call() To Send Funds

ambrosus · May 19, 2024 · 528d0ac · 528d0ac
1 parent a417f20
commit 528d0ac
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/contracts/contracts/common/CommonBridge.sol b/contracts/contracts/common/CommonBridge.sol
@@ -106,8 +106,10 @@ contract CommonBridge is Initializable, AccessControlUpgradeable, PausableUpgrad
 
         uint amount = msg.value - transferFee - bridgeFee;
         feeCheck(wrapperAddress, feeSignature, transferFee, bridgeFee, amount);
-        transferFeeRecipient.transfer(transferFee);
-        bridgeFeeRecipient.transfer(bridgeFee);
+        (bool sent, ) = payable(transferFeeRecipient).call{value: transferFee}("");
+        require(sent, "Transfer failed (transferFee)");
+        (sent, ) = payable(bridgeFeeRecipient).call{value: bridgeFee}("");
+        require(sent, "Transfer failed (bridgeFee)");
 
         IWrapper(wrapperAddress).deposit{value : amount}();