Changed rules 1002 according to issue 33 #34
Conversation
This allow to cover Password which doesn't start immediately with the P as the MyPassw0rd example.
|
|
| @@ -16,7 +16,7 @@ | |||
| Searcharea: body | |||
| rules: | |||
| - Code: 1002 | |||
| Pattern: (?i)"p[a4@][s$][s$]w[o0]rd([#!@]?(123)?)?" | |||
| Pattern: (?i)"*p[a4@][s$][s$]w[o0]rd([#!@]?(123)?)?" | |||
There was a problem hiding this comment.
is this PR pertaining to issue -> #33
Then this does not look like the right way to handle it. We would need to create a new rule to address the pattern. This particular pattern is looking for the term password.
There was a problem hiding this comment.
I thought it was easier to extend this rule than to create a new one as this rule already covers "password" but also its variants with numbers and special characters and it even covers when it is followed by special characters and numbers. So I thought having some characters at the beginning will follow the same principle. Reject the PR if you think it's better. I'll create another rule then
|
Closing the PR as the approach is not correct for the issue. |
This allow to cover Password which doesn't start immediately with the P as the MyPassw0rd example.