-
Notifications
You must be signed in to change notification settings - Fork 28
refactor(one-app-runner): use semver for app version comparison #608
Conversation
990d97e
to
94da5fa
Compare
There was some concern from @Matthew-Mallimo here that semver wouldn't work right if the image was just "one-app-dev:5" |
There is unit test coverage for that use case. And as far as adding another dep, its already a dep of the bundler and I dont there are many cases of people installing the runner without that |
I will also be adding another case of version detection required for tracing support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case where the supplied docker image is just one-app:5
?
@Matthew-Mallimo That test case already exists on line 411 |
Description
Refactor app version comparison to use semver
Motivation
Semver is more reliable than manual comparison
Test Conditions
Refactor - existing unit tests cover the change and still pass & added new test to cover prerelease use case
Types of changes
Check boxes that apply:
Checklist
Check boxes that apply: