Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rbd_algorithms.py #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update rbd_algorithms.py #97

wants to merge 2 commits into from

Conversation

Giaco02
Copy link

@Giaco02 Giaco02 commented Sep 1, 2024

I incorporated joint acceleration into the reduced RNEA


📚 Documentation preview 📚: https://adam-docs--97.org.readthedocs.build/en/97/

I incorporated joint acceleration into the reduced RNEA
@traversaro traversaro requested a review from Giulero September 2, 2024 09:18
@Giulero
Copy link
Collaborator

Giulero commented Sep 2, 2024

Hi @Giaco02, thanks for the PR!
The tests are failing since the variable q_dot_dot is never instantiated. Maybe some commits are missing!

added joint accelerations to rnea (i  uploaded the wrong version in the first pr)
@Giaco02
Copy link
Author

Giaco02 commented Sep 2, 2024

Hi @Giulero , you were right about the issues, and I’ve now made the necessary commit.

@Giulero
Copy link
Collaborator

Giulero commented Sep 10, 2024

Hi @Giaco02! Thanks for fixing this and sorry for the late reply
However there are some missing pieces :)
For adapting rnea, we would also need the base acceleration in the formulation as input of the function apart from the joint one.
Also, some tests against idyntree would be super useful!
Thanks!

@traversaro how can we test rnea with system acceleration with idyntree?

@traversaro
Copy link
Contributor

traversaro commented Sep 10, 2024

\n@traversaro how can we test rnea with system acceleration with idyntree?

Sure, you need to set acceleration with the appropriate method or pass acceleration to the inverseDinamics method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants