Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove homebrew job from CI #822

Merged
merged 10 commits into from
Apr 5, 2024
Next Next commit
Install manifpy from cmake in CI
  • Loading branch information
GiulioRomualdi committed Apr 4, 2024
commit 0853c43a8814ae27330173c6b0c108dc1d0e9475
11 changes: 2 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ jobs:
mkdir build
cd build
cmake -A x64 -DCMAKE_TOOLCHAIN_FILE=${VCPKG_INSTALLATION_ROOT}/scripts/buildsystems/vcpkg.cmake \
-DBUILD_PYTHON_BINDINGS:BOOL=ON \
-DCMAKE_PREFIX_PATH=${GITHUB_WORKSPACE}/install/deps \
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
-DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/install/deps ..
Expand Down Expand Up @@ -425,7 +426,7 @@ jobs:
git checkout ${manif_TAG}
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/install/deps ..
cmake -DBUILD_PYTHON_BINDINGS:BOOL=ON -DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/install/deps ..
cmake --build . --config ${{ matrix.build_type }} --target install -j${{env.NUM_CORES_FOR_CMAKE_BUILD}}

# matioCpp
Expand Down Expand Up @@ -502,14 +503,6 @@ jobs:

cmake --build . --config ${{ matrix.build_type }} --target install -j${{env.NUM_CORES_FOR_CMAKE_BUILD}}

- name: Install manifpy [Ubuntu/macOS]
if: startsWith(matrix.os, 'ubuntu') || matrix.os == 'macos-latest'
run: |
git clone https://github.com/artivis/manif.git manifpy
cd manifpy
git checkout ${manif_TAG}
python3 -m pip install .

- name: Check Python setup
shell: bash
run: |
Expand Down