Add rpc commands to YarpLoggerDevice #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoreMoretti
changed the title
LoreMoretti
changed the title
LoreMoretti
requested review from
GiulioRomualdi and
S-Dafarra
as code owners
S-Dafarra
reviewed
Dec 2, 2024
traversaro
reviewed
Dec 2, 2024
devices/YarpRobotLoggerDevice/thrifts/YarpRobotLoggerDeviceCommands.thrift
Outdated
Show resolved
Hide resolved
traversaro
reviewed
Dec 2, 2024
devices/YarpRobotLoggerDevice/include/BipedalLocomotion/YarpRobotLoggerDevice.h
Outdated
Show resolved
Hide resolved
…mands.thrift Co-authored-by: Silvio Traversaro <[email protected]>
S-Dafarra
reviewed
Dec 3, 2024
devices/YarpRobotLoggerDevice/include/BipedalLocomotion/YarpRobotLoggerDevice.h
Outdated
Show resolved
Hide resolved
…botLoggerDevice.h Co-authored-by: Stefano Dafarra <[email protected]>
S-Dafarra
reviewed
Dec 3, 2024
devices/YarpRobotLoggerDevice/thrifts/YarpRobotLoggerDeviceCommands.thrift
Outdated
Show resolved
Hide resolved
…mands.thrift Co-authored-by: Giulio Romualdi <[email protected]>
traversaro
reviewed
Dec 4, 2024
devices/YarpRobotLoggerDevice/thrifts/YarpRobotLoggerDeviceCommands.thrift
Outdated
Show resolved
Hide resolved
traversaro
reviewed
Dec 4, 2024
devices/YarpRobotLoggerDevice/thrifts/YarpRobotLoggerDeviceCommands.thrift
Outdated
Show resolved
Hide resolved
…mands.thrift Co-authored-by: Silvio Traversaro <[email protected]>
S-Dafarra
approved these changes
Dec 5, 2024
|
Thank you @LoreMoretti,, the CI failures is not related to the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a rpc command to the
YarpLoggerDevice.This command should be used to trigger YarpLoggerDevice to save data to local file (which currently is only possible by closing the device itself with ctrl+c).
I have added a command which saves according to the method
robometry::SaveCallbackSaveMethod::periodic.