-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow to override default config/log_config.yaml by a custom one #87
fix: allow to override default config/log_config.yaml by a custom one #87
Conversation
@sami-racho-scalac, I think you are right, but even better would be to not store the logs on a potentially ephemeral pod filesystem. I'll be happy to update the chart to accommodate this or wait for you to reopen the PR . |
Yeah, the pr needs more work. My objective is to being able to override the default log_config.yaml, but my current approach doesn't work. |
@sami-racho-scalac, I get you. The chart does create a |
That's what I tried but if I'm not wrong helm doesn't allow to use files outside the chart. |
@sami-racho-scalac in theory you can use a whole string containing the yaml config file and set that via something like I think it might make sense to expose logging configuration via variables and inject those into a template (one thing that helm is actually good at). What do yo think? Which parts of the logging config do you want to update? |
In my case I just need to change the log levels |
ok, that seems simple enough. I'll push the change today unless you want to contribute this as PR? My idea is to treat the logging config as yaml file and then pass the logging params such as log level as one of the template params to fill in. On a related note, I'm mostly done with an observability layer with OTEL, Prometheus, Grafana, Loki etc. I'll also add that to the chart over the next week. |
Then I leave it in your hands. Thanks! |
@sami-racho-scalac, added logging level support via |
Perfect! Thx so much. |
Right now is not possible to replace the default config/log_config.yaml file.
So I think the value
logConfigFileLocation
should be used as path to render the configmap.