-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: New constructor with raw JSON as input (PR is WIP) #55
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 73.53% 73.52% -0.02%
==========================================
Files 5 5
Lines 1436 1443 +7
==========================================
+ Hits 1056 1061 +5
- Misses 210 211 +1
- Partials 170 171 +1
|
Haven't had time to write this out yet, but here's why I added it: https://github.com/yunginnanet/ziggs/blob/2705ff6140f9f18f805eaba297339a6f5d62a97c/ziggy/lights.go#L371-L401 Essentially my bridge is firewalled off from the internet - this means it can't call home to phillips to do its little discovery function. As an alternative (and very barbaric) discovery method my app offers to port scan the chosen LAN interface and then enumerate the addresses that respond for status callbacks. When it gets a hit, it uses that JSON to construct a bridge type using the NewCustom function. |
Hey @yunginnanet Thanks for contributing. Let me know once you are ready for review (no longer draft) |
- What I did
- How I did it
- How to verify it
- Description for the CHANGELOG