Dhruv/merging_branch_tin_changes #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DerivFE <[email protected]>
…com#16976) * feat: ✨ hide fiat onramp for unsupported currencies * fix(wallets): 🚑 align back button and transaction status * style(cashier): 💄 fix side note order in mobile view, remove onramp box, improve logic
…update (deriv-com#17058) * chore: cashier crypto disclaimer content update * fix: update font weight * fix: currency name
…eriv-com#17057) * chore: deposit crypto disclaimer content update * fix: update font weight * fix: currency name
…com#17051) * fix: pa transfer to client rtl ui issues * fix: update classname * fix: applied comments * fix: add new text var * fix: pa transfer receipt ui issues
Co-authored-by: DerivFE <[email protected]>
deriv-com#16992) * feat: do not render UI based on partial data!!!! * feat: hide close button while its loading
* fix: minor ui issues * fix: scroll issue * fix: blog link * fix: a tag color
…riv-com#17074) * fix: derivx create password button disable * fix: enter password disable check
…v-com#17120) * fix: deposit disclaimer content change * fix: unit test
…test master (deriv-com#17121) * fix: dbot console errors * fix: dbot console errors * fix: dbot console errors * fix: dbot console errors
Co-authored-by: DerivFE <[email protected]>
…wahili ,Simplified and Traditional chinese languages [SW,ZH_CN,ZH_TW] (deriv-com#17003) * fix: remove dependencies from trade type translation * refactor: apply suggestions
…-com#16645) * feat: change default chart style from ticks to candles * fix: some logic * feat: refactor default chart logic completely * fix: add new property to mockStore * fix: failing test case * fix: apply correct url params when ticks contarct is opened * feat: add failsafe condition * fix: remove extra logic * fix: remove unused variable
…iv-com#17109) * fix: ctrader success modal spacing issue * fix: applied comments
Co-authored-by: DerivFE <[email protected]>
…ake on symbol change (deriv-com#17024) * feat: add stake default value * feat: set stake back to default on trade type switch * feat: reset tp on trade type swicth * refactor: add crypto currency convertion * feat: add stake convertion after account switch * chore: remove code smells * refactor: save converted value in localstorage and applied in trade tsx * refactor: add tests * feat: reset stake on symbol change * refactor: move logic to trade store * fix: reset stake for crypto
* chore: duration fixes * fix: fix * fix: added 24 h * chore: test case fi * chore: test case fi * chore: end time fix * chore: test cases * chore: key fix * chore: fix * chore: disable quill PR udpated * fix: fixing undefined * chore: changing wuill version * chore: final fix * fix: test case * chore: screen added * chore: ui completed * chore: UI is fixed with error added * chore: old test cases fixes * chore: test case fix * chore: fixing ts errors * chore: end time fix * chore: fixing test case * fix: test case * chore: changing time to 23 * chore: time in test case * chore: fixing snackbar * chore: setting end time when gmt time changes * fix: fix * chore: setting disabling days * chore: fixing hout * chore: fixes * chore: test case * chore: adding gmt+0 * chore: test case fix * chore: fixes * chore: just extracting utility function * chore: oops extra import * chore: setting sheet height when only one unit * fix: getting updated time on each date change * fix: showing end time for bull and bear * chore: trigger * fix: test cases * chore: fix * fix: 24 hour for wheel picker * chore: changing end time when current time is bigger * chore: handling the issue of not updating expiry date
* fix: Fix--for-onboarding-tour * fix: Fix--for-onboarding-tour * fix: for prettier
* fix: open accumulators video when clicking on learn more * chore: rename variable * fix: accumulators loading on bot builder
…om#17071) * fix: phone number + icon not align properly in arabic * chore: make phone number to be ltr in phone otp page * chore: remove unicode-bidi * chore: fix phone number verified modal phone number alignment
* chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event
…unt signup (deriv-com#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <[email protected]> Co-authored-by: Likhith Kolayari <[email protected]>
…com#17236) Co-authored-by: nada-deriv <[email protected]>
…#17239) Co-authored-by: Likhith Kolayari <[email protected]>
…17244) Co-authored-by: Likhith Kolayari <[email protected]>
…ssible mt5 pop up … (deriv-com#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message
* feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <[email protected]>
…ix TP/SL history title (deriv-com#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update
* fix: livechat icon on testlinks * fix: country data for growthbook
* fix: add livechat widget call check * fix: whatsapp issue on freshchats * chore: pass country to growthbook on login using cloudflare check * fix: import issue * chore: added test case for getCountry * fix: test error
* fix: eslint errors occured during merge (deriv-com#17227) * fix: destroy instead of minimize (deriv-com#17229) * fix: redirection fro staging to p2p staging (deriv-com#17231) * fix: idv update in real account creation (deriv-com#17235) * fix: misaligned employment-status field (deriv-com#17242) * fix: incorporated CSS changes * fix: issue with duplicate account --------- Co-authored-by: prince-deriv <[email protected]> Co-authored-by: nada-deriv <[email protected]>
…com#16800) * feat(wallets): ✨ implement WalletDialog component * fix(wallets): 🐛 fix and rename get button * fix(wallets): 🧪 fix broken test * feat(wallets): ✨ add WalletStatusBadge component * refactor(wallets): ♻️ refactor WalletsDialog * chore: include disabled accounts in the account list * chore: ignore disabled accounts while filtering default wallets * chore: upgrade ui package * chore: add section wrapper with bottom border to trading account card * chore: add badge to wallet dropdown * chore: add disabled badge and modal for options account * chore: add badge and modal fro disabled mt5 account * chore: conditionally render add more wallets section * chore: disable real demo switcher for disabled wallets * chore: add disabled account banner * chore: update inline message variant * chore: remove unnecessary class name * chore: use css colour variable * chore: update badge icon * chore: update testid * test: add more unit tests * test: fix failing tests * chore: add unit tests and address reviews * chore: remove unnecessary props * chore: remove unnecessary code * style: sort keys * test: update is_disabled value to true * chore: remove unnecessary class and add aria attribute * chore: resolve sonarcloud issue * chore: update ui package version * chore: address review comments * chore: hide disabled wallet from account switcher on the dtrader header * chore: disable trading platforms if options account is disabled * chore: hide options account if it is disabled * chore: make the badge bright * chore: make mt5 badge active * chore: update badge color * chore: update modal height for tablet * chore: update badge colour * chore: disable left and right icon for disabled cfds * chore: disable buttons only if the options account is disabled * chore: add logout on authorize failure * chore: fix build and resolve sonarcloud failure * chore: resolve logged out header issue * chore: update badge size * ci: fix failing tests * ci: resolve build failure * ci: rename folder from test to tests and delete duplicate file * chore: add check for error code * chore: await logout * chore: conditionally add styles for disabled options account and localize and * chore: apply suggested changes * chore: replace then with try catch * chore: return no token if an account is disabled after login * chore: update localstorage with new account details after authorize * chore: filter out options account when the options account or the wallet and options are disabled --------- Co-authored-by: heorhi-deriv <[email protected]> Co-authored-by: George Usynin <[email protected]>
…d on theme (deriv-com#17222) * fix: change loading screen color based on theme * fix: make changes v2 only
…7243) * fix: add Continue Trading button in POI * chore: fix test case fail issue
* fix: multiple fixes for stake field * feat: show empty field error message only after saving
…rom pinned and unpinned in draggable list to prevent glitch (deriv-com#17067) * fix: change the way we remove trade types from pinned and unpinned * fix: remove comment * fix: magical margin
Co-authored-by: DerivFE <[email protected]>
Dhruv-deriv
requested review from
amina-deriv,
matin-deriv,
yashim-deriv,
vinu-deriv,
hirad-deriv and
likhith-deriv
as code owners
likhith-deriv
approved these changes
Oct 22, 2024
likhith-deriv
merged commit 76d5404
into
amina-deriv:dhruv/amina_mt5_defaulting_jurisdiction
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Merging the LAtest Master changes onto branch