Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple PK model containing boolean values #670

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix multiple PK model containing boolean values #670

merged 2 commits into from
Nov 13, 2023

Conversation

ncarvajalc
Copy link
Contributor

Closes #669

aminalaee
aminalaee requested changes Nov 13, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor change.

sqladmin/helpers.py Outdated Show resolved Hide resolved
@aminalaee aminalaee changed the title Fixed false value being cast to True when getting primary key Fix multiple PK model containing boolean values Nov 13, 2023
aminalaee
aminalaee approved these changes Nov 13, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@aminalaee aminalaee merged commit 52df929 into aminalaee:main Nov 13, 2023
6 checks passed
@aminalaee aminalaee mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object identifier values function not parsing correctly path parameters when a field is False
2 participants
@ncarvajalc @aminalaee