Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add json export format. #829

Merged
merged 5 commits into from
Oct 17, 2024
Merged

add json export format. #829

merged 5 commits into from
Oct 17, 2024

Conversation

Vasiliy566
Copy link
Contributor

@Vasiliy566 Vasiliy566 commented Oct 9, 2024 •
edited
Loading

Add json-format to export.

@Vasiliy566
Copy link
Contributor Author

@aminalaee review please

aminalaee
aminalaee reviewed Oct 14, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. Just a minor comment.

sqladmin/models.py Outdated Show resolved Hide resolved
@Vasiliy566
Copy link
Contributor Author

add name convert to string.

aminalaee
aminalaee approved these changes Oct 17, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍

@aminalaee aminalaee merged commit 402780f into aminalaee:main Oct 17, 2024
5 checks passed
@aminalaee aminalaee mentioned this pull request Oct 17, 2024
Merged
@Vasiliy566 Vasiliy566 mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZharkovMihail ZharkovMihail ZharkovMihail approved these changes

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vasiliy566 @aminalaee @ZharkovMihail