fix: handle pagination issue when search results do not match current… #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page Corrected behavior to automatically redirect users to the first page if the current search result has fewer pages than the page they were on. This prevents an error where a search performed from a non-existent page number would cause incorrect behavior (“Invalid page or pageSize parameter”)
… page Corrected behavior to automatically redirect users to the first page if the current search result has fewer pages than the page they were on. This prevents an error where a search performed from a non-existent page number would cause incorrect behavior (“Invalid page or pageSize parameter”)
aminalaee
reviewed
Oct 14, 2024
|
Hi, I believe this is a duplicate of #814. The approach is different in that this change redirects you to the first page, whereas 814 redirects to the maximum allowed page. |
|
Yeah I think you are right. This can be closed then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a pagination issue in SQLAdmin where performing a search from a page other than the first page would result in an error (“Invalid page or pageSize parameter”) if the search results had fewer pages than the current page.
Changes
Testing