fix: expression minor bugs (request#3074)

amitkanfer · Dec 12, 2018 · e81c9b1 · e81c9b1
1 parent b3926a3
commit e81c9b1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/auth.js b/lib/auth.js
@@ -62,7 +62,7 @@ Auth.prototype.digest = function (method, path, authHeader) {
 
   var challenge = {}
   var re = /([a-z0-9_-]+)=(?:"([^"]+)"|([a-z0-9_-]+))/gi
-  for (;;) {
+  while (true) {
     var match = re.exec(authHeader)
     if (!match) {
       break

diff --git a/lib/har.js b/lib/har.js
@@ -172,7 +172,7 @@ Har.prototype.options = function (options) {
     req.postData.params.forEach(function (param) {
       var attachment = {}
 
-      if (!param.fileName && !param.fileName && !param.contentType) {
+      if (!param.fileName && !param.contentType) {
         options.formData[param.name] = param.value
         return
       }

diff --git a/request.js b/request.js
@@ -1448,7 +1448,7 @@ Request.prototype.jar = function (jar) {
     cookies = false
     self._disableCookies = true
   } else {
-    var targetCookieJar = (jar && jar.getCookieString) ? jar : globalCookieJar
+    var targetCookieJar = jar.getCookieString ? jar : globalCookieJar
     var urihref = self.uri.href
     // fetch cookie in the Specified host
     if (targetCookieJar) {