Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Expiration Minutes to Dashboard #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukaalba
Copy link

@lukaalba lukaalba commented Nov 9, 2018

There is only a column whether a link is expired or not and I think it is useful to see additionally, what value was set during the creation of the short link.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.973% when pulling 1a50038 on lukaalba:add_expire into 81e1de0 on amitt001:master.

@amitt001
Copy link
Owner

amitt001 commented Nov 10, 2018

@lukaalba Good idea and thanks for the PR.

I think it would be more informative to a user if there is an exact timestamp link expired. Would you like to modify your pr to show 'Expire At'?

Expire at can be calculated by adding created_at + timedelat(expire_after).

@lukaalba
Copy link
Author

@amitt001 great idea, but I'm new to Python and Django. Can you tell me which file(s) I need to edit?

@amitt001
Copy link
Owner

amitt001 commented Dec 6, 2018

@lukaalba apologies for the late reply. It's this file
https://github.com/amitt001/pygmy/blob/master/pygmyui/templates/pygmy/dashboard.html#L15
You already get all the data required for calculating that value

You can reference this file as this contains keys that are returned https://github.com/amitt001/pygmy/blob/master/pygmy/model/link.py#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants