Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the core/navigation block and style #344

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Gentyspun
Copy link
Contributor

Ref: #316

Re-enables the core/navigation block, adds a block style for a grey background and styles the block to match the old custom Menu block.

Flickity functionality for the front end is going to be handled at a later date in a separate ticket

Steps to test:

  1. Edit a post
  2. Open the block inserter and search for navigation (you may need to disable the branding plugin if it doesn't show)
  3. Insert the block, and populate, it should match the styles of the old custom Menu block
  4. Check and change the block style to grey background
  5. Save and view on the front end

Considerations:

  • RTL: Needs to be tested for RTL users to ensure the block displays correctly

Example:
http://bigbite.im/i/cnKyZT

@Gentyspun Gentyspun requested a review from jaymcp August 6, 2024 09:04
@Gentyspun Gentyspun marked this pull request as draft August 6, 2024 09:28
@Gentyspun Gentyspun marked this pull request as ready for review August 7, 2024 09:20
jaymcp
jaymcp previously requested changes Aug 14, 2024
Copy link
Contributor

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but the frontend renders a different menu to what I expect. I set it to output a sample menu, and the "toxic twitter" menu was instead output during preview. Any ideas?

private/src/styles/blocks/core-blocks/_navigation.scss Outdated Show resolved Hide resolved
private/src/styles/blocks/core-blocks/_navigation.scss Outdated Show resolved Hide resolved
private/src/styles/blocks/core-blocks/_navigation.scss Outdated Show resolved Hide resolved
@Gentyspun
Copy link
Contributor Author

I'm not sure why, but the frontend renders a different menu to what I expect. I set it to output a sample menu, and the "toxic twitter" menu was instead output during preview. Any ideas?

Hmmm, very strange. I tried to replicate and I see the correct menu

@jaymcp
Copy link
Contributor

jaymcp commented Aug 14, 2024

I'm not sure why, but the frontend renders a different menu to what I expect. I set it to output a sample menu, and the "toxic twitter" menu was instead output during preview. Any ideas?

Hmmm, very strange. I tried to replicate and I see the correct menu

I wonder if it's because the converted menus are for some reason drafts, barring the "toxic twitter" one? When I select a classic menu, it converts okay, but it's not published. Since one can't view drafts on the frontend under normal circumstances, perhaps it's just pulling in the only published one:

jaymcp
jaymcp previously requested changes Sep 10, 2024
private/src/styles/blocks/core-blocks/_navigation.scss Outdated Show resolved Hide resolved
private/src/styles/blocks/core-blocks/_navigation.scss Outdated Show resolved Hide resolved
@jaymcp
Copy link
Contributor

jaymcp commented Dec 4, 2024

moving to draft re #316 (comment)

@jaymcp jaymcp marked this pull request as draft December 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants